Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to deduplicate extern blocks #2258

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Aug 25, 2022

This PR adds a new option --merge-extern-blocks which merges all the extern blocks with the same ABI and attributes in a single one.

Fixes #564.
Blocked by: #2265.

@amanjeev amanjeev requested review from emilio and kulp August 29, 2022 16:17
@pvdrz pvdrz marked this pull request as draft September 6, 2022 21:14
@bors-servo
Copy link

☔ The latest upstream changes (presumably 8b29355) made this pull request unmergeable. Please resolve the merge conflicts.

@pvdrz pvdrz marked this pull request as ready for review September 10, 2022 01:27
@emilio emilio merged commit 4b006da into rust-lang:master Sep 23, 2022
@pvdrz pvdrz deleted the deduplicate-extern-blocks branch September 23, 2022 16:55
qsdrqs pushed a commit to qsdrqs/rust-bindgen that referenced this pull request Oct 26, 2022
LoganBarnett pushed a commit to LoganBarnett/rust-bindgen that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it always necessary to put every function definition in a separate extern block?
3 participants