Derive from any other trait only when deriving from Copy #2200
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
derive-must-copy
branch
6 times, most recently
from
c8bc986
to
84a2ec0
Compare
emilio
requested changes
May 4, 2022
vadorovsky
force-pushed
the
derive-must-copy
branch
2 times, most recently
from
5ba9bd2
to
dea052e
Compare
|
@emilio Good point, it should be fixed now. |
vadorovsky
force-pushed
the
derive-must-copy
branch
from
dea052e
to
606cf91
Compare
emilio
approved these changes
May 4, 2022
vadorovsky
force-pushed
the
derive-must-copy
branch
from
606cf91
to
3a7ba55
Compare
It's impossible to #[derive] from any other trait when not deriving from Copy when using the newest Rust nightly. Any attempt to do that results in the following error: error: `#[derive]` can't be used on a `#[repr(packed)]` struct that does not derive Copy (error E0133) Fixes: rust-lang#2083 Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
vadorovsky
force-pushed
the
derive-must-copy
branch
from
3a7ba55
to
e8805de
Compare
|
Thank you for review! I like the idea with using just bool without Option, I applied it. |
emilio
approved these changes
May 7, 2022
There was a problem hiding this comment.
Thanks, this looks good for now. I think this might not be fully correct in the presence of a non-packed struct containing a packed struct... For that we probably need to track this properly in the CanDerive analysis.
That shouldn't be too hard, but doing this in the meantime is fine.
|
@emilio Good call, I will try to address that in a separate PR |
This was referenced Jun 1, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's impossible to #[derive] from any other trait when not deriving from
Copy when using the newest Rust nightly. Any attempt to do that results
in the following error:
Fixes: #2083
Signed-off-by: Michal Rostecki vadorovsky@gmail.com