Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing regression test for #1973. #1979

Merged
merged 1 commit into from Jan 30, 2021

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Jan 30, 2021

#1973

failures:

---- test_homogeneous_aggregate_float_union stdout ----
thread 'test_homogeneous_aggregate_float_union' panicked at 'assertion failed: `(left == right)`
  left: `[1.0, 2.0, 3.0, 4.0]`,
 right: `[0.00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000029021264197102883, 0.0, 0.0, 0.0]`', src/lib.rs:268:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@frewsxcv
Copy link
Member Author

Are integration tests run in CI?

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are integration tests run in CI?

Yes, though on x86-64 (so I think it won't trigger that issue).

This looks good to me though, thanks!

@emilio emilio merged commit c509ef1 into rust-lang:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants