Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use path_for_whitelisting instead of canonical_path when matching #1893

Closed
wants to merge 2 commits into from
Closed

Use path_for_whitelisting instead of canonical_path when matching #1893

wants to merge 2 commits into from

Conversation

johnmave126
Copy link
Contributor

for enum type specification and template opaque type specification.

Resolves #1891

@johnmave126
Use path_for_whitelisting instead of canonical_path when matching
ce74307 
for enum type specification and template opaque type specification
@johnmave126
Copy link
Contributor Author

Did look into having a test case, but seems unfit to current testing framework since there is no parse callback in command line.

@johnmave126
Copy link
Contributor Author

r? @emilio

emilio
emilio approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but we should be able to add a test to bindgen-integration/, which allows parse callbacks. If that's too hard for some reason though, please explain and I can merge as is.

Thank you!

@johnmave126
Copy link
Contributor Author

Made two tests. One for enum and one for template.

emilio
emilio approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you! I'll merge this manually to avoid that formatting change, but looks great otherwise.

bindgen-integration/build.rs Show resolved Hide resolved
@emilio
Copy link
Contributor

emilio commented Sep 14, 2020

f4d10c3

@emilio emilio closed this Sep 14, 2020
@johnmave126 johnmave126 deleted the enum-name-filtering branch September 14, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

*_enum() takes item name after parse_callbacks processing instead of before
2 participants
@johnmave126 @emilio