Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to make which dependency optional #1615

Merged
merged 7 commits into from Sep 17, 2019
Merged

Add a feature to make which dependency optional #1615

merged 7 commits into from Sep 17, 2019

Commits on Sep 5, 2019

  1. Add which-rustfmt feature

    This feature controls whether bindgen will use the which crate to detect
    the rustfmt binary. This makes which an optional dependency.
    
    which-rustfmt is a default feature which makes this change backward compatible.
    lopopolo committed Sep 5, 2019
    Copy the full SHA
    f64287d View commit details
    Browse the repository at this point in the history
  2. Do not use which if which-rustfmt feature is disabled

    This commit changes the API of rustfmt_path to return Result<Option<Cow<PathBuf>>>.
    
    Ok(None) is returned in the case where which is disabled and no rustfmt command is
    supplied explicitly either via configuration or env variable.
    
    Downstream code checks for the presence of None to directly return the source without
    emitting an error.
    lopopolo committed Sep 5, 2019
    Copy the full SHA
    b97192b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. Copy the full SHA
    af4eebd View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    258940a View commit details
    Browse the repository at this point in the history
  3. lint ci/script.sh

    lopopolo committed Sep 16, 2019
    Copy the full SHA
    ebd8d4d View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    e627649 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    c22fcf3 View commit details
    Browse the repository at this point in the history