Add proc_macro crate for the 1.56 ABI #9806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might need to run
I think we can keep three versions (stable, beta, nightly). Technically, 1.55 is beta, right? |
alexjg
force-pushed
the
proc-macro-abi-1_56
branch
from
6f2a234
to
b111357
Compare
|
Yup, forgot to run the Three versions sounds good, I'll leave 1.55 in then, this should be good to go. |
|
Thanks for taking care of this! bors r+ |
|
changelog feat add support for the 1.56 nightly proc macro ABI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've copied the latest proc macro source from Rust nightly and modified it to compile on
stable. This fixes #9795 . Almost everything here is uninteresting copy and paste, the interesting stuff is incrates/proc_macro_srv/src/abis/mod.rs. I've left the 1.55 ABI implementation in for now. We did discuss only supporting one nightly ABI so we may want to remove 1.55. That will break code which is pinned to older nightly releases but that seems acceptable to me, what do people think?