feat: more accurate memory usage info on glibc Linux #9204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Jun 11, 2021
| if mallinfo2 == 1 { | ||
| let cstr = CStr::from_bytes_with_nul(b"mallinfo2\0").unwrap(); | ||
| mallinfo2 = unsafe { libc::dlsym(libc::RTLD_DEFAULT, cstr.as_ptr()) } as usize; | ||
| // NB: races don't matter here, since they'll always store the same value |
There was a problem hiding this comment.
Interesting! OnceCell sort-of has a type for this, but using it would seem to be more awkward: https://docs.rs/once_cell/1.7.2/once_cell/race/struct.OnceNonZeroUsize.html
bors
added a commit
to rust-lang/libc
that referenced
this pull request
Jun 11, 2021
Bump version to 0.2.97 I'd like to get a new release published, since I want to make use of #2228 in rust-lang/rust-analyzer#9204
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new
mallinfo2API added in glibc 2.33. It addresses a shortcoming in themallinfoAPI where it was unable to handle memory usage of more than 2 GB, which we sometimes exceed.Blocked on rust-lang/libc#2228