Remove flycheck -> LSP dependency #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be only one place that knows about LSP, and that place is right before we spit JSON on stdout.
|
Build succeeded: |
kjeremy
reviewed
May 15, 2020
|
|
||
| #[derive(Debug)] | ||
| pub enum Status { | ||
| Being, |
kiljacken
reviewed
May 15, 2020
| @@ -300,15 +266,11 @@ fn run_cargo( | |||
| // erroneus output. | |||
| let stdout = BufReader::new(child.stdout.take().unwrap()); | |||
| let mut read_at_least_one_message = false; | |||
|
|
|||
| for line in stdout.lines() { | |||
There was a problem hiding this comment.
This might cause a regression with regards to how we handle junk output from stdout usage in build scripts, proc macros, etc, unless the issue has been fixed upstream.
There was a problem hiding this comment.
Ahh, I see oli-obk/cargo_metadata#106 should address this issue! Awesome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+
馃