feat: Add proc macro ABI for rustc 1.58 #10769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
reviewed
Nov 16, 2021
Veykril
reviewed
Nov 16, 2021
alexjg
force-pushed
the
proc-macro-abi-1.58
branch
from
2b2c143
to
abdb2ac
Compare
|
Thanks @Veykril |
|
bors r+ |
lnicola
changed the title
|
...however, |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2022
11797: fix: fix "unwrap on a `None` value" in proc macros built with Rust 1.57.0 r=jonas-schievink a=jonas-schievink Closes #10570 cc #10769 (comment) bors r+ Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10766.
I do have some concerns here. The proc macro server API has added three methods to
TokenStreamwhich I don't really know how to implement inRustcServer. Namelyexpand_expr,before, andafter. You'll see that these are currentlyunimplemented!incrates/proc_macro_server/src/abis/abi_1_58/rustc_server.rs. I don't have the expertise to fill in the blanks here, it may be necessary to pull in someone who knows a bit more about the proc macro crate.I think this will only be a problem when actually attempting to expand a macro, so this is probably strictly better than not including the updated ABI at all.