Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Generic member access for dyn Error trait objects #3461

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

RFC: Generic member access for dyn Error trait objects #3461

wants to merge 43 commits into from

Commits on Jul 20, 2023

  1. Initial commit for first rfc

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    46bb80d View commit details
    Browse the repository at this point in the history

  2. First wave of edits

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    47cc77d View commit details
    Browse the repository at this point in the history

  3. more edits

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f638485 View commit details
    Browse the repository at this point in the history

  4. more edits

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7fd3bdb View commit details
    Browse the repository at this point in the history

  5. maybe time to start showing ppl this

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1027612 View commit details
    Browse the repository at this point in the history

  6. simplify summary

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3a6a6a9 View commit details
    Browse the repository at this point in the history

  7. oops, didnt realize this was a suggested edit

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    45e4705 View commit details
    Browse the repository at this point in the history

  8. post eliza review

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    43d659a View commit details
    Browse the repository at this point in the history

  9. Adams comments

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    dd8a63b View commit details
    Browse the repository at this point in the history

  10. rewrite to focus on nika's version

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    b31fe0c View commit details
    Browse the repository at this point in the history

  11. proof reading

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1dd49d9 View commit details
    Browse the repository at this point in the history

  12. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ea945f4 View commit details
    Browse the repository at this point in the history

  13. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ed38f90 View commit details
    Browse the repository at this point in the history

  14. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ba0e1bf View commit details
    Browse the repository at this point in the history

  15. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6fcc1b1 View commit details
    Browse the repository at this point in the history

  16. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    8968547 View commit details
    Browse the repository at this point in the history

  17. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d274fd4 View commit details
    Browse the repository at this point in the history

  18. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    af8981e View commit details
    Browse the repository at this point in the history

  19. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    5a7e47d View commit details
    Browse the repository at this point in the history

  20. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    41ec1ec View commit details
    Browse the repository at this point in the history

  21. boop

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6049030 View commit details
    Browse the repository at this point in the history

  22. fix attribution to be less confusing and mention source

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    60b82e8 View commit details
    Browse the repository at this point in the history

  23. nikanit

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    b8e5b92 View commit details
    Browse the repository at this point in the history

  24. Update text/0000-dyn-error-generic-member-access.md 

    Co-authored-by: kennytm <kennytm@gmail.com>
    @yaahc @kennytm @waynr
    2 people authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    9f52696 View commit details
    Browse the repository at this point in the history

  25. rename to provide_context

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c983ddd View commit details
    Browse the repository at this point in the history

  26. Update based on kennys changes

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f2e4f72 View commit details
    Browse the repository at this point in the history

  27. Document divergence from object-provider crate

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6944d14 View commit details
    Browse the repository at this point in the history

  28. Add example to code snippet

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a2cb4b5 View commit details
    Browse the repository at this point in the history

  29. update to include nikas updates

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a622c30 View commit details
    Browse the repository at this point in the history

  30. Update text/0000-dyn-error-generic-member-access.md 

    Co-authored-by: Adam Perry <lol@anp.lol>
    @yaahc @anp @waynr
    2 people authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1768e57 View commit details
    Browse the repository at this point in the history

  31. Apply suggestions from code review 

    Co-authored-by: Adam Perry <lol@anp.lol>
    @yaahc @anp @waynr
    2 people authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6ca88bb View commit details
    Browse the repository at this point in the history

  32. reply to adams coments

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    61259be View commit details
    Browse the repository at this point in the history

  33. make type_id fn in Request private

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c650a65 View commit details
    Browse the repository at this point in the history

  34. remove type_id fn

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c3faa49 View commit details
    Browse the repository at this point in the history

  35. update example to use successors

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f556131 View commit details
    Browse the repository at this point in the history

  36. add back missing write

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f24561f View commit details
    Browse the repository at this point in the history

  37. update rfc to include new object provider API

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6c313f7 View commit details
    Browse the repository at this point in the history

  38. add examples for by value

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2ec0c5c View commit details
    Browse the repository at this point in the history

  39. Apply suggestions from code review 

    Co-authored-by: bstrie <865233+bstrie@users.noreply.github.com>
    @yaahc @bstrie @waynr
    2 people authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a59d39c View commit details
    Browse the repository at this point in the history

  40. update RFC to be based on dyno design

    @yaahc @waynr
    yaahc authored and waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7d9692f View commit details
    Browse the repository at this point in the history

  41. update guide-level example code

    @waynr
    waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    5ef13c0 View commit details
    Browse the repository at this point in the history

  42. fix typo

    @waynr
    waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    53e35ba View commit details
    Browse the repository at this point in the history

  43. update the guide-level explanation

    @waynr
    waynr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    0cffa52 View commit details
    Browse the repository at this point in the history