Fix a bug in capture with match #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing "EndText" matching, it is necessary to check whether the current position matches the input text length.However, when capturing a submatch using the matching result of DFA, "EndText" matching wasn't actually performed correctly because the input text is sliced. By applying this patch we specify the match end position by the argument "end", not using slice when performing capture with the matching result of DFA. Fixes rust-lang#557
BurntSushi
requested changes
Mar 10, 2019
There was a problem hiding this comment.
Lovely, thank you! I think this looks good to me. One small request though:
could you please make sure all new code introduced in this PR is in a style
consistent with the surrounding code? In particular, please make sure all lines
are wrapped to 79 columns inclusive.
|
I formatted the code. |
BurntSushi
pushed a commit
that referenced
this pull request
Mar 30, 2019
When performing "EndText" matching, it is necessary to check whether the current position matches the input text length. However, when capturing a submatch using the matching result of DFA, "EndText" matching wasn't actually performed correctly because the input text is sliced. By applying this patch we specify the match end position by the argument "end", not using slice when performing capture with the matching result of DFA. Fixes #557, Closes #561
|
Thank you for reviewing and merging! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing "EndText" matching, it is necessary to check whether
the current position matches the input text length.However, when
capturing a submatch using the matching result of DFA, "EndText" matching
wasn't actually performed correctly because the input text is sliced.
By applying this patch we specify the match end position by the argument "end",
not using slice when performing capture with the matching result of DFA.
Fixes #557