introduce feature gate into never-type test #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
approved these changes
Dec 14, 2019
|
I thought this would fail the stable-check, but it looks like the stable-check doesn't recurse into subdirectories. 😢 I will try to fix that some point in the future. Sorry this caused a hiccup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we are rolling back stabilization of the never type, this example needs a feature gate. The test was added only recently, by @ehuss -- I think that ordinarily we don't document unstable features, but given that this section of the book seems to be older, and that
!can appear in some places, and that we hope to get!stabilized very soon, I opted not to remove it.This needs to land semi-urgently so that rust-lang/rust#67224 can land.