-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document guarantee about evaluation of associated consts and const blocks #1497
Conversation
52b889c
to
1e2a01a
Compare
aac08bb
to
da8e435
Compare
Blocked on rust-lang/rust#124971 |
da8e435
to
673ef58
Compare
673ef58
to
d33e4b0
Compare
I think that we'll plausibly end up with a stronger guarantee than what's discussed here, but the basic one of "if it's 'executed' it'll definitely be evaluated" as proposed here seems like an entirely reasonable and hopefully uncontroversial minimal first step. @rfcbot fcp merge |
@rfcbot merge |
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
@rfcbot reviewed |
🔔 This is now entering its final comment period, as per the review above. 🔔 psst @joshtriplett, I wasn't able to add the |
@rfcbot reviewed |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. psst @joshtriplett, I wasn't able to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes rust-lang/rust#112090
I think this has been our intention for a while (ever since rust-lang/rust#67191 landed), but was never properly decided, so it likely needs t-lang FCP.