Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document guarantee about evaluation of associated consts and const blocks #1497

Merged
merged 1 commit into from
May 25, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 10, 2024

Fixes rust-lang/rust#112090

I think this has been our intention for a while (ever since rust-lang/rust#67191 landed), but was never properly decided, so it likely needs t-lang FCP.

@RalfJung RalfJung changed the title document guarantee about evaluation of associated consts document guarantee about evaluation of associated consts and const blocks May 10, 2024
@RalfJung RalfJung force-pushed the const-eval-guarantee branch 4 times, most recently from aac08bb to da8e435 Compare May 10, 2024 13:52
@RalfJung
Copy link
Member Author

Blocked on rust-lang/rust#124971

@scottmcm
Copy link
Member

I think that we'll plausibly end up with a stronger guarantee than what's discussed here, but the basic one of "if it's 'executed' it'll definitely be evaluated" as proposed here seems like an entirely reasonable and hopefully uncontroversial minimal first step.

@rfcbot fcp merge

@joshtriplett joshtriplett added the T-lang Team: Lang label May 15, 2024
@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link

rfcbot commented May 15, 2024

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@tmandry
Copy link
Member

tmandry commented May 15, 2024

@rfcbot reviewed

@rfcbot
Copy link

rfcbot commented May 15, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @joshtriplett, I wasn't able to add the final-comment-period label, please do so.

@nikomatsakis
Copy link
Contributor

@rfcbot reviewed

@rfcbot
Copy link

rfcbot commented May 25, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

psst @joshtriplett, I wasn't able to add the finished-final-comment-period label, please do so.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue May 25, 2024
Merged via the queue into rust-lang:master with commit 1bf2cdc May 25, 2024
1 check passed
@joshlf joshlf mentioned this pull request May 25, 2024
50 tasks
@RalfJung RalfJung deleted the const-eval-guarantee branch May 26, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are (non-free) generic constants guaranteed to be evaluated?
7 participants