Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'.inst' in inline-assembly changed to '.insn' #1453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CyoeeA9e
Copy link

The correct directive name should be .insn. Here is the issue in rust repository.

@ehuss
Copy link
Contributor

ehuss commented Jan 25, 2024

I'm a bit confused, as I believe .inst is a valid directive still. What is the difference between them? Is there some more information about this change?

@Amanieu Can you provide some information here?

@Amanieu
Copy link
Member

Amanieu commented Jan 25, 2024

Both are correct: .inst is used on ARM, .insn is used in RISC-V.

@ehuss
Copy link
Contributor

ehuss commented Apr 30, 2024

@joshtriplett Do you want to add .insn to the guaranteed directive list? (Not what this PR does, it should be added not replaced.)

Looks like .insn was added to gnu-as in 2018 in bminor/binutils-gdb@0e35537 and in llvm in llvm-14 in llvm/llvm-project@2838797 (I think, from some quick googling).

@Amanieu
Copy link
Member

Amanieu commented Apr 30, 2024

I'm happy to add it in addition to .inst.

@joshtriplett
Copy link
Member

@ehuss Yeah, that seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants