Document method-call expressions in pseudo-code as well as prose #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
method-call-expr-pseudo-code
branch
from
0ddce00
to
4d80b79
Compare
adetaylor
reviewed
Dec 5, 2023
|
|
||
| // Then, for each candidate `T`, add `&T` and `&mut T` to the list | ||
| // immediately after `T`. | ||
| let candidate_receiver_types = candidate_receiver_types.map(|T| [T, &T, &mut T]).flatten(); |
There was a problem hiding this comment.
flat_map? I know this is just pseudo-Rust!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally find the documentation on method-call expressions very hard to grok, and I suspect I'm not the only one, so I thought I would attempt to rewrite the section in pseudo-code, to hopefully make the algorithm clearer.
This is done as a precursor to fixing #718 and #1018, which is important for RFC 3519 where we're trying to change the algorithm.