Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: prefer immutable #163

Merged
merged 2 commits into from Feb 20, 2024
Merged

style: prefer immutable #163

merged 2 commits into from Feb 20, 2024

Conversation

nomyfan
Copy link
Contributor

@nomyfan nomyfan commented Feb 20, 2024

Code style changes.

@nomyfan nomyfan closed this Feb 20, 2024
@sdroege
Copy link
Collaborator

sdroege commented Feb 20, 2024

This requires at least Rust 1.41, while the MSRV here is 1.30.

@nomyfan
Copy link
Contributor Author

nomyfan commented Feb 20, 2024

It seems that 1.3.0 doesn't have map_or, so close it.

@nomyfan nomyfan deleted the style/immutable branch February 20, 2024 10:06
@nomyfan nomyfan restored the style/immutable branch February 20, 2024 10:15
@nomyfan
Copy link
Contributor Author

nomyfan commented Feb 20, 2024

It supports 1.30.0 now, pls take a look 👀

@nomyfan nomyfan reopened this Feb 20, 2024
@sdroege sdroege merged commit 246ece2 into rust-lang:master Feb 20, 2024
8 checks passed
@sdroege
Copy link
Collaborator

sdroege commented Feb 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nomyfan @sdroege