Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions actions/checkout@v2 to v3 #2092

Merged
merged 1 commit into from Apr 30, 2022

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Apr 30, 2022

The v2 implementation uses Node 12, which is end-of-life on April 30, 2022. See https://nodejs.org/en/about/releases/. Update to v3, which is based on Node 16 whose support lasts until April 30, 2024.

The v2 implementation uses Node 12, which is end-of-life on April 30, 2022.
See https://nodejs.org/en/about/releases/. Update to v3, which is based on
Node 16 whose support lasts until April 30, 2024.
@oli-obk
Copy link
Contributor

oli-obk commented Apr 30, 2022

@bors r+

It probably would've worked beyond today, just been unsupported, right?

@bors
Copy link
Collaborator

bors commented Apr 30, 2022

📌 Commit 0bdf91d has been approved by oli-obk

@bors
Copy link
Collaborator

bors commented Apr 30, 2022

⌛ Testing commit 0bdf91d with merge 0fce9f4...

@bors
Copy link
Collaborator

bors commented Apr 30, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 0fce9f4 to master...

@bors bors merged commit 0fce9f4 into rust-lang:master Apr 30, 2022
@RalfJung
Copy link
Member

RalfJung commented Apr 30, 2022

Is there any user-visible change in behavior?
(I am trying to understand why this Node update was considered a breaking change in terms of semver.)

@bjorn3
Copy link
Member

bjorn3 commented Apr 30, 2022

actions/checkout#689 (comment): looks like it is because older github enterprise versions don't support nodejs 16 and thus bumping actions/checkout to nodejs 16 would break them.

@dtolnay dtolnay deleted the checkoutv3 branch April 30, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants