migrate to a single workspace #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate the build setup for all crates to use 2021-style cargo.toml with workspaces. Note that the `tests/` dir has an unusual setup, where the tests dir is both a separate crate and a set of integration tests for the log crate. I am not certain of all the interactions here, and making it into a regular test crate breaks the filter test, so leaving as is for now until someone can explain what's going on there.
|
Thanks for the PR @nyurik! Sorry for the delayed response here. The integration test project is a bit of an oddity, but it seems like pulling everything into a single workspace adds to the confusion rather than reducing it. I think this could be something to revisit in the future, but for the time being the status quo is less machinery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate the build setup for all crates to use 2021-style cargo.toml with workspaces. Note that the
tests/dir has an unusual setup, where the tests dir is both a separate crate and a set of integration tests for the log crate.I am not certain of all the interactions here, and making it into a regular test crate breaks the filter test, so leaving as is for now until someone can explain what's going on there.