Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns api #3667

Closed
wants to merge 1 commit into from
Closed

Add dns api #3667

wants to merge 1 commit into from

Conversation

aviramha
Copy link

@aviramha aviramha commented Apr 27, 2024

Adding structs and functions defined in dnsinfo.h which is private, so no libc tests (or any idea for a workaround?)
The functions are exported via libSystem.dylib so symbol resolution should be okay.
Closes #3666

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor
Copy link
Member

Thank you for the PR! We, however, don't accept private items generally and would like not to introduce those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants