Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the value of FAN_MARK_IGNORE #3622

Merged
merged 1 commit into from May 1, 2024

Conversation

severen
Copy link
Contributor

@severen severen commented Mar 17, 2024

This PR aligns the value of FAN_MARK_IGNORE in libc with that in uapi/linux/fanotify.h.

Previously, it was incorrectly set to the value of FAN_MARK_MOUNT, which can cause subtle but catastrophic bugs when one tries to mark a file as ignored.

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@severen
Copy link
Contributor Author

severen commented Mar 17, 2024

I've also gone through and compared all of the other fanotify constants with those in uapi/linux/fanotify.h to see if I could spot any other mismatches, but it looks like everything else is correct.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

@JohnTitor JohnTitor added this pull request to the merge queue May 1, 2024
Merged via the queue into rust-lang:libc-0.2 with commit 71a1ee6 May 1, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants