Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add memmem GNU extension for haiku #3165

Merged
merged 1 commit into from Mar 28, 2023
Merged

Conversation

devnexen
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 28, 2023

📌 Commit fb2a763 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 28, 2023

⌛ Testing commit fb2a763 with merge a7c13b9...

@bors
Copy link
Contributor

bors commented Mar 28, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing a7c13b9 to master...

@bors bors merged commit a7c13b9 into rust-lang:master Mar 28, 2023
9 of 10 checks passed
@nielx
Copy link
Contributor

nielx commented Apr 25, 2023

@devnexen What is this libunix.so you try to link against? It does not seem to be part of Haiku.

@devnexen
Copy link
Contributor Author

ah yes it s part of libgnu I can see in the last haiku snapshot, seems it s already taking care of.

@JohnTitor
Copy link
Member

@devnexen I'm always happy to see your PRs and your contributions are great, but please make sure everything isn't broken on your end before submitting a PR (IIRC a similar thing happened by your PR in the past). CI doesn't check for all the targets, unfortunately (and I'm not the expert for all the supported targets, sorry).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants