FreeBSD: move all new ABI to base module, add more O_ flags #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to rust-lang#3023, new ABI did not need to be hidden away under cfg(freebsdXX) flags, only changed ABI!
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
JohnTitor
approved these changes
Feb 12, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So according to #3023 all of that stuff didn't need to be hidden away in these conditionally built modules and we could've been exposing
eventfd,getrandom,getentropy,setproctitle_fastetc. to crates.io consumers all this time…While in the test file, clean up the mess in
skip_fn:)Other thing we need to expose is
O_PATH,O_RESOLVE_BENEATHfor crates like cap-std/openat. While here, add other open flags.