Migrate from highfive to triagebot

[ehuss]

This migrates this repository from using the highfive bot to using triagebot (aka rustbot).

This should not be merged without coordinating the removal of the highfive webhook and/or merging rust-lang/highfive#433.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

[JohnTitor]

Thank you! @bors r+

[bors]

📌 Commit 8e874bd has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8e874bd with merge 605f6c3...

[ehuss]

Oh, please don't merge yet. This needs infra work first.

This should not be merged

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 605f6c3 to master...

[ehuss]

@JohnTitor This should not have been merged. I'm concerned that the bots will conflict with one another and possibly get into a loop. Can you revert it please?

[JohnTitor]

Ah sorry, I didn't read the description carefully!
However, is there any blocker of rust-lang/highfive#433? I'm not sure why it's still open.

[JohnTitor]

I'm concerned that the bots will conflict with one another and possibly get into a loop.

Also, I'm not sure how the loop is caused, is it an implementation issue? If I opened a revert PR, the issue could occur, right? Then I think waiting for the above highfive PR to be merged would be fine as the rate of PRs here isn't high.

[ehuss]

However, is there any blocker of rust-lang/highfive#433? I'm not sure why it's still open.

We have to wait for infra to do it. It can take time for people to get around to things, and this wasn't intended to be something dealt with quickly.

Also, I'm not sure how the loop is caused, is it an implementation issue?

I haven't tested, but the concern is that both bots will be handling r? commands. In the welcome message, both bots print an r? text. One bot will respond to the other's command and vice-versa. I'm not sure if they will get in a war with each other trying to set the assignment. I suppose since they only print one message, it should only result in one duplicate, but I'm not sure. There are additional error message comments that get posted that may contain additional r? commands, I don't remember.

If I opened a revert PR, the issue could occur, right?

Hm, I'm not sure, possibly. Is the master branch protected? I don't suppose you can push directly to it?

[JohnTitor]

Thanks for clarifying! I see, I'm going to revert then.

Is the master branch protected?

Yes, we have, and I cannot modify it.

At least, highfive will print the below for my PRs and r? loops won't happen, I guess.

@JohnTitor: no appropriate reviewer found, use r? to override