Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle c circular dependence (linux gnu) #3013

Merged
merged 1 commit into from Nov 27, 2022

Conversation

belovdv
Copy link
Contributor

@belovdv belovdv commented Nov 23, 2022

Repeating libc allows solve this fixme in rust compiler.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@petrochenkov
Copy link
Contributor

This is not exactly what the hack in rustc does, but -lc -lgcc_eh -lgcc -lc implemented here should work fine, I checked what interdependencies these libraries have.

@JohnTitor
Copy link
Member

Thank you for the PR and review! @bors r=JohnTitor,petrochenkov

@bors
Copy link
Contributor

bors commented Nov 27, 2022

📌 Commit 141a890 has been approved by JohnTitor,petrochenkov

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 27, 2022

⌛ Testing commit 141a890 with merge c943911...

@bors
Copy link
Contributor

bors commented Nov 27, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor,petrochenkov
Pushing c943911 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants