Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI to use Android NDK r25b #2956

Closed
wants to merge 1 commit into from

Conversation

chriswailes
Copy link

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

Thanks for the PR! I've, however, updated the toolchain on #2955, closing in favor of that.

@JohnTitor JohnTitor closed this Oct 11, 2022
@chriswailes
Copy link
Author

A couple of comments on #2955:

  1. The use of make_standalone_toolchain.py is no longer recommended and using it with the compiler wrappers is explicitly not supported. See https://developer.android.com/ndk/guides/other_build_systems
  2. The Android Platform Support document says that rustc should target the lowest level API supported by a target for a given NDK unless there is a specific reason a higher API level is needed. If libc needs to use API level 28 we should update the rustc CI and document it.
  3. Updates to aarch-linux-android/Dockerfile, arm-linux-androideabi/Dockerfile, and x86_64-linux-android/Dockerfile are missing.

@chriswailes chriswailes mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants