apple add pthread_jit_write_callback_t api related. #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
devnexen
force-pushed
the
pthread_jit_mac_upd
branch
3 times, most recently
from
86a3a3e
to
4ba4e21
Compare
devnexen
force-pushed
the
pthread_jit_mac_upd
branch
from
4ba4e21
to
52b45a7
Compare
JohnTitor
approved these changes
Sep 2, 2022
|
Looks good! @bors r+ |
bors
added a commit
that referenced
this pull request
Sep 2, 2022
apple add pthread_jit_write_callback_t api related.
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
bors
added a commit
that referenced
this pull request
Sep 29, 2022
Use `::Option` and not `Option` for `pthread_jit_write_callback_t` The `pthread_jit_write_callback_t` type alias (introduced by #2896) uses `Option` rather than `::Option`, which causes problems when trying to update the `libc` dependency that `std` has. (Please cut a release after merging this <3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.