Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add makedev for the BSDs #2891

Merged
merged 1 commit into from Sep 9, 2022
Merged

Add makedev for the BSDs #2891

merged 1 commit into from Sep 9, 2022

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Aug 26, 2022

Also, make Linux's makedev function safe and const.

@rust-highfive
Copy link

Some changes occurred in OpenBSD module

cc @semarie

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@asomers
Copy link
Contributor Author

asomers commented Aug 26, 2022

cc @musikid

@semarie
Copy link
Contributor

semarie commented Aug 27, 2022

LGTM for openbsd.

just a question about the type used for the function definition: why using c_uint (and casting it to dev_t) instead of dev_t directly ?

@asomers
Copy link
Contributor Author

asomers commented Aug 27, 2022

LGTM for openbsd.

just a question about the type used for the function definition: why using c_uint (and casting it to dev_t) instead of dev_t directly ?

Just because that's what the existing Linux definition does.

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Aug 29, 2022

📌 Commit f776f0e has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 29, 2022

⌛ Testing commit f776f0e with merge 0d83fa0...

bors added a commit that referenced this pull request Aug 29, 2022
@bors
Auto merge of #2891 - asomers:makedev, r=JohnTitor
0d83fa0 
Add makedev for the BSDs

Also, make Linux's makedev function safe and const.
@bors
Copy link
Contributor

bors commented Aug 29, 2022

💔 Test failed - checks-actions

@asomers
Copy link
Contributor Author

asomers commented Aug 29, 2022

Ahh, crap. I forgot about FreeBSD 11.

@JohnTitor
Copy link
Member

👍, @bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2022

📌 Commit 3de218a has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 5, 2022

⌛ Testing commit 3de218a with merge c9fb3b6...

bors added a commit that referenced this pull request Sep 5, 2022
@bors
Auto merge of #2891 - asomers:makedev, r=JohnTitor
c9fb3b6 
Add makedev for the BSDs

Also, make Linux's makedev function safe and const.
@bors
Copy link
Contributor

bors commented Sep 5, 2022

💔 Test failed - checks-actions

@asomers
Copy link
Contributor Author

asomers commented Sep 5, 2022

@JohnTitor I think this should fix the bors error. But I don't know how to run the tests on emscripten except by asking bors to merge.

@asomers
Copy link
Contributor Author

asomers commented Sep 6, 2022

@JohnTitor I think if you do " bors delegate=asomers" then that will give me permission to use "bors try". It'll also give me permission to merge the PR, but I promise not to do that unless you say so ;) .

@JohnTitor
Copy link
Member

👍, @bors delegate+

@bors
Copy link
Contributor

bors commented Sep 6, 2022

✌️ @asomers can now approve this pull request

@asomers
Copy link
Contributor Author

asomers commented Sep 6, 2022

@bors try

@bors
Copy link
Contributor

bors commented Sep 6, 2022

⌛ Trying commit 4f006af with merge 6a390b5...

bors added a commit that referenced this pull request Sep 6, 2022
@bors
Auto merge of #2891 - asomers:makedev, r=<try>
6a390b5 
Add makedev for the BSDs

Also, make Linux's makedev function safe and const.
@bors
Copy link
Contributor

bors commented Sep 6, 2022

💔 Test failed - checks-actions

@asomers
Copy link
Contributor Author

asomers commented Sep 6, 2022

bors try

@asomers
Copy link
Contributor Author

asomers commented Sep 6, 2022

@bors try

@bors
Copy link
Contributor

bors commented Sep 6, 2022

⌛ Trying commit 8486fd7 with merge 9fb9ec1...

bors added a commit that referenced this pull request Sep 6, 2022
@bors
Auto merge of #2891 - asomers:makedev, r=<try>
9fb9ec1 
Add makedev for the BSDs

Also, make Linux's makedev function safe and const.
@bors
Copy link
Contributor

bors commented Sep 7, 2022

💔 Test failed - checks-actions

@asomers
Copy link
Contributor Author

asomers commented Sep 7, 2022

@bors try

bors added a commit that referenced this pull request Sep 7, 2022
@bors
Auto merge of #2891 - asomers:makedev, r=<try>
fe38ca1 
Add makedev for the BSDs

Also, make Linux's makedev function safe and const.
@bors
Copy link
Contributor

bors commented Sep 7, 2022

⌛ Trying commit f26839a with merge fe38ca1...

@bors
Copy link
Contributor

bors commented Sep 7, 2022

💔 Test failed - checks-actions

@asomers
Copy link
Contributor Author

asomers commented Sep 7, 2022

@bors try

@bors
Copy link
Contributor

bors commented Sep 7, 2022

⌛ Trying commit 3a615a0 with merge b24118e...

bors added a commit that referenced this pull request Sep 7, 2022
@bors
Auto merge of #2891 - asomers:makedev, r=<try>
b24118e 
Add makedev for the BSDs

Also, make Linux's makedev function safe and const.
@bors
Copy link
Contributor

bors commented Sep 7, 2022

☀️ Try build successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Build commit: b24118e (b24118e1548647bf39969ef7459552d7fe03a3d1)

@asomers
Add makedev for the BSDs
5e6d9c4 
Also, make makedev function safe and const on all platforms.

On Android, change the arguments from signed to unsigned integers to
match the other platforms.  The C makedev is a macro, so the
signededness is undefined.

Add an integration test for makedev, too, since it's a macro that we
must reimplement.
@asomers
Copy link
Contributor Author

asomers commented Sep 7, 2022

@JohnTitor it finally passes CI, I've squashed my commits.

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2022

📌 Commit 5e6d9c4 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 9, 2022

⌛ Testing commit 5e6d9c4 with merge 6eee580...

@bors
Copy link
Contributor

bors commented Sep 9, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 6eee580 to master...

@bors bors merged commit 6eee580 into rust-lang:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor Awaiting requested review from JohnTitor

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@asomers @rust-highfive @semarie @JohnTitor @bors @Amanieu