Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: add rtnetlink mcast group definitions #2889

Merged
merged 1 commit into from Sep 2, 2022

Conversation

phi-gamma
Copy link
Contributor

These come in two flavors:

  • RTNLGRP_* are bit indexes (arguments to setsockopt(2)) as used
    in the kernel with test_bit() but also userspace (see libnl
    examples).

  • RTMGRP_* are bitmasks not used in the kernel; their use
    seems to be deprecated, at least according to comments in
    libnl, but documentation still references them.

The rationale for adding these definitions is that they're needed
to subscribe to kernel events via Netlink multicast groups.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@phi-gamma phi-gamma force-pushed the rtnetlink-mcast-groups branch 2 times, most recently from f0143c9 to 921a470 Compare August 24, 2022 07:59
@bors
Copy link
Contributor

bors commented Aug 24, 2022

☔ The latest upstream changes (presumably #2876) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2022

📌 Commit c74a65c has been approved by JohnTitor

It is now in the queue for this repository.

bors added a commit that referenced this pull request Aug 31, 2022
linux: add rtnetlink mcast group definitions

These come in two flavors:

- RTNLGRP_* are bit indexes (arguments to setsockopt(2)) as used
  in the kernel with test_bit() but also userspace (see libnl
  examples).

- RTMGRP_* are bitmasks not used in the kernel; their use
  seems to be deprecated, at least according to comments in
  libnl, but documentation still references them.

The rationale for adding these definitions is that they're needed
to subscribe to kernel events via Netlink multicast groups.
@bors
Copy link
Contributor

bors commented Aug 31, 2022

⌛ Testing commit c74a65c with merge 94e60ce...

@bors
Copy link
Contributor

bors commented Aug 31, 2022

💔 Test failed - checks-actions

These come in two flavors:

- RTNLGRP_* are bit indexes (arguments to setsockopt(2)) as used
  in the kernel with test_bit() but also userspace (see libnl
  examples).

- RTMGRP_* are bitmasks not used in the kernel; their use
  seems to be deprecated, at least according to comments in
  libnl, but documentation still references them.

The rationale for adding these definitions is that they're needed
to subscribe to kernel events via Netlink multicast groups.
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 2, 2022

📌 Commit d2e04b9 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 2, 2022

⌛ Testing commit d2e04b9 with merge 795adbe...

@bors
Copy link
Contributor

bors commented Sep 2, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 795adbe to master...

@bors bors merged commit 795adbe into rust-lang:master Sep 2, 2022
@phi-gamma
Copy link
Contributor Author

phi-gamma commented Sep 2, 2022

Thanks @JohnTitor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants