Complete i686-unknown-linux-musl ucontext_t #2787

[victorpaleologue]

Fix #2787

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

[victorpaleologue]

I tested it successfully with the reproduction steps explained in the issue, after patching all mentions of the libc dependency so that it points to this branch of the repository.

[Amanieu]

@bors r+

[bors]

📌 Commit e86eeec has been approved by Amanieu

[bors]

⌛ Testing commit e86eeec with merge ce4d314...

[bors]

💔 Test failed - checks-actions

[Amanieu]

Tests are complaining about incomplete types. You probably need to include an additional header file in libc-test/build.rs.

[JohnTitor]

Friendly-ping, @victorpaleologue could you address the CI failure?

[victorpaleologue]

Sorry I took so long to react.
The logs are not available anymore.
Can someone re-trigger the build so that I can check the error logs?

[victorpaleologue]

@bors r+

[bors]

@victorpaleologue: 🔑 Insufficient privileges: Not in reviewers

[victorpaleologue]

@victorpaleologue: 🔑 Insufficient privileges: Not in reviewers

That was worth trying =p

[JohnTitor]

Contributors aren't allowed to r+ PRs in general otherwise anyone could push any changes to the master 😆

@bors try

[bors]

⌛ Trying commit e86eeec with merge b901b57...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

@bors try

[bors]

⌛ Trying commit 804ffa4 with merge 81e4217...

[bors]

💔 Test failed - checks-actions

[victorpaleologue]

Sorry I'm using an arm64 processor and I don't understand yet how to run the i686 tests on my machine. Would you please trigger the CI again?

[bors]

💔 Test failed - checks-actions

[bors]

☔ The latest upstream changes (presumably #2915) made this pull request unmergeable. Please resolve the merge conflicts.

[victorpaleologue]

@bors try

[bors]

⌛ Trying commit 89cd883 with merge 6416f9c...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

Friendly-ping @victorpaleologue, are you still working on this?

[victorpaleologue]

Not really.
I wish I could keep on working on that to get things straight, but as far as I can see, I'm not able to satisfy every platform as I should.
Let's get @bors try again and see if I get inspired by its results. Otherwise I'll have to admit defeat!

[bors]

⌛ Trying commit 89cd883 with merge fc16066...

[bors]

💔 Test failed - checks-actions

[victorpaleologue]

I think this is a progress. Something's fishy with the FreeBSD 14 job, the error seems unrelated to my work. Let's ask @bors try again and hope this time it'll be ok. On my end I'll clean my commits.

[bors]

⌛ Trying commit 8bb4cff with merge d8a7448...

[bors]

💔 Test failed - checks-cirrus-freebsd-14

[victorpaleologue]

FreeBSD 14 again. Perhaps I'll come back later to try again.

[JohnTitor]

The failure is unrelated to this PR, I'll address next week ;) (I'm on small vacation this week)

[victorpaleologue]

@bors try

[bors]

⌛ Trying commit 1873e91 with merge 86fa4ba...

[bors]

💔 Test failed - checks-actions

[victorpaleologue]

Hello, I think I am stuck, I do not know how to go further.
The type _fpstate is meant to have an anonymous struct in the field _st according to musl's toolchain.
But Rust does not provide a way to declare this, so the generated Rust code is not compatible with that header.

I will close this PR now, but if anyone has an idea, please share!