Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pthread_mutexattr_setprotocol and pthread_mutexattr_getprotocol on Linux #2731

Merged
merged 1 commit into from Apr 24, 2022

Conversation

rtzoeller
Copy link
Contributor

@rtzoeller rtzoeller commented Mar 22, 2022

Include the PTHREAD_PRIO_* constants.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@rtzoeller rtzoeller force-pushed the pthread_prio_inherit branch 2 times, most recently from ecb52e0 to 3830d48 Compare March 22, 2022 03:43
@Amanieu
Copy link
Member

Amanieu commented Mar 22, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 22, 2022

📌 Commit 3830d48 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Mar 22, 2022

⌛ Testing commit 3830d48 with merge 9170da2...

bors added a commit that referenced this pull request Mar 22, 2022
Add pthread_mutexattr_setprotocol and pthread_mutexattr_getprotocol on Linux-like platforms

Include the PTHREAD_PRIO_* constants. Android does not define PTHREAD_PRIO_PROTECT.
@bors
Copy link
Contributor

bors commented Mar 22, 2022

💔 Test failed - checks-actions

@rtzoeller
Copy link
Contributor Author

AFAICT the failures were not related to this change.

@Amanieu
Copy link
Member

Amanieu commented Mar 27, 2022

We currently have emscripten as a linux-like platform but it doesn't support this function.

@Amanieu
Copy link
Member

Amanieu commented Mar 30, 2022

To clarify, the actual failure is in the emscripten tests (click on the link from bors, then look for the asmjs builder on the left), which doesn't have these functions.

@rtzoeller rtzoeller changed the title Add pthread_mutexattr_setprotocol and pthread_mutexattr_getprotocol on Linux-like platforms Add pthread_mutexattr_setprotocol and pthread_mutexattr_getprotocol on Linux and Android Apr 8, 2022
@Amanieu
Copy link
Member

Amanieu commented Apr 8, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2022

📌 Commit f6cf436 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Apr 8, 2022

⌛ Testing commit f6cf436 with merge 3113440...

bors added a commit that referenced this pull request Apr 8, 2022
Add pthread_mutexattr_setprotocol and pthread_mutexattr_getprotocol on Linux and Android

Include the PTHREAD_PRIO_* constants. Android does not define PTHREAD_PRIO_PROTECT.
@bors
Copy link
Contributor

bors commented Apr 8, 2022

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Apr 10, 2022

@bors retry

@bors
Copy link
Contributor

bors commented Apr 10, 2022

⌛ Testing commit f6cf436 with merge 6359a2b...

bors added a commit that referenced this pull request Apr 10, 2022
Add pthread_mutexattr_setprotocol and pthread_mutexattr_getprotocol on Linux and Android

Include the PTHREAD_PRIO_* constants. Android does not define PTHREAD_PRIO_PROTECT.
@bors
Copy link
Contributor

bors commented Apr 10, 2022

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Apr 10, 2022

It seems these functions don't exist on Android? Or our Android version in CI is too old. Feel free to upgrade it if that is the case.

…n Linux

Include the PTHREAD_PRIO_* constants.
@rtzoeller rtzoeller changed the title Add pthread_mutexattr_setprotocol and pthread_mutexattr_getprotocol on Linux and Android Add pthread_mutexattr_setprotocol and pthread_mutexattr_getprotocol on Linux Apr 24, 2022
@rtzoeller
Copy link
Contributor Author

I don't have a good way to validate the functionality on Android, so I've updated the PR to be Linux only.

@Amanieu
Copy link
Member

Amanieu commented Apr 24, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2022

📌 Commit 91395ae has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Apr 24, 2022

⌛ Testing commit 91395ae with merge f6df53f...

@bors
Copy link
Contributor

bors commented Apr 24, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing f6df53f to master...

@bors bors merged commit f6df53f into rust-lang:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants