Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI for armv7-unknown-linux-uclibceabihf #2640

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

skrap
Copy link
Contributor

@skrap skrap commented Jan 21, 2022

As discussed in #2636, this is a framework for CI on targets with no prebuilt std. They will build via nightly and -Zbuild-std, and run the unit tests via qemu-user (or whatever else the dockerfile specifies).

It seems like I could write some more documentation about how to add more targets of this type, but perhaps I can get a round of feedback on the mechanism here before I go and write that.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@skrap
Copy link
Contributor Author

skrap commented Jan 21, 2022

I don't know that I agree with shellcheck's warning here. I want to split EXTRA_CARGO_ARGS on spaces. shellcheck's docs call out this valid use case, but their sh-compatible workaround is to put the whole call in a function and use $@, which feels like a pretty big change (and IMO pretty ugly). Instead I'll just make the solution less general and not try to build a general extra args feature.

@Amanieu
Copy link
Member

Amanieu commented Jan 21, 2022

LGTM!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2022

📌 Commit d93b11d has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Jan 21, 2022

⌛ Testing commit d93b11d with merge 804cef7...

bors added a commit that referenced this pull request Jan 21, 2022
add CI for armv7-unknown-linux-uclibceabihf

As discussed in #2636, this is a framework for CI on targets with no prebuilt std.  They will build via `nightly` and `-Zbuild-std`, and run the unit tests via qemu-user (or whatever else the dockerfile specifies).

It seems like I could write some more documentation about how to add more targets of this type, but perhaps I can get a round of feedback on the mechanism here before I go and write that.
@skrap
Copy link
Contributor Author

skrap commented Jan 21, 2022

Great! Once this is merged, feel free to @mention me on any CI failures involving uclibc. I'll be happy to help them get resolved.

@bors
Copy link
Contributor

bors commented Jan 21, 2022

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Jan 21, 2022

CI is also spewing a bunch of errors along the lines "/toolchain/relocate-sdk.sh: 39: file: not found".

@skrap
Copy link
Contributor Author

skrap commented Jan 21, 2022

CI is also spewing a bunch of errors along the lines "/toolchain/relocate-sdk.sh: 39: file: not found".

Yeah, I just pushed a fix for that, thanks for the heads up.

@Amanieu
Copy link
Member

Amanieu commented Jan 21, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2022

📌 Commit bc9e590 has been approved by Amanieu

@skrap
Copy link
Contributor Author

skrap commented Jan 21, 2022

Huh, I don't think bors ran anything for that commit. Did I break it somehow??

@Amanieu
Copy link
Member

Amanieu commented Jan 21, 2022

@bors retry

@Amanieu
Copy link
Member

Amanieu commented Jan 21, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jan 21, 2022

📌 Commit bc9e590 has been approved by Amanieu

@Amanieu
Copy link
Member

Amanieu commented Jan 21, 2022

There seems to have been some issue with the macOS runners in CI. I restarted the jobs and it seems to be working now.

@bors
Copy link
Contributor

bors commented Jan 21, 2022

⌛ Testing commit bc9e590 with merge 8bba79c...

@bors
Copy link
Contributor

bors commented Jan 21, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 8bba79c to master...

@bors bors merged commit 8bba79c into rust-lang:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants