freebsd: Correctly detect FreeBSD version #2603
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the CI check that applies to freebsd version cfg. This is causing problems where the freebsd version defaults to 11 when CI is not enabled, some types may be incorrect on a > 11 system,
and compilation failures ensue.
A concrete example is libc::dev_t. This was defaulting to u32 on my FreeBSD 13-STABLE desktop, when it should have been u64. I couldn't compile anything that uses libc::devname_r as a result.