Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix invalid freebsd version selection" #2585

Merged
merged 1 commit into from Dec 10, 2021

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Dec 10, 2021

This reverts commit 53e79b8.

PR #2581 unintentionally changed libc's bindings from the FreeBSD 11 ABI
to the native ABI of the build host. This is causing breakage for many
downstream crates.

This reverts commit 53e79b8.

PR rust-lang#2581 unintentionally changed libc's bindings from the FreeBSD 11 ABI
to the native ABI of the build host.  This is causing breakage for many
downstream crates.
@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Dec 10, 2021

@bors r+

I've yanked libc 0.1.110 which has the issue.

@bors
Copy link
Contributor

bors commented Dec 10, 2021

📌 Commit 727d37a has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Dec 10, 2021

⌛ Testing commit 727d37a with merge c9c8872...

@bors
Copy link
Contributor

bors commented Dec 10, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing c9c8872 to master...

@bors bors merged commit c9c8872 into rust-lang:master Dec 10, 2021
bors added a commit that referenced this pull request May 31, 2022
Remove workarounds for old FreeBSDs on libc-test

Fixes #2546

This doesn't remove cfgs for old FreeBSDs as [it caused a regression in the past](#2585).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants