Add documentation for kinfo_proc fields #2552
Conversation
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
r? @JohnTitor |
|
I've moved the declaration in #2545 so this will need a rebase after it's merged. |
|
Ah interesting, you did what I did originally but I thought it wasn't worth it because only a few fields changed. Makes more sense though. I'll wait for github to tell me that it's not mergeable then. Thanks for the head up! |
|
☔ The latest upstream changes (presumably #2545) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
kinfo_proc-doc
branch
from
a1df065
to
0785135
Compare
|
CI is happy. |
|
@bors r+ |
|
📌 Commit 0785135 has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
| /// Text size (pages) XXX. | ||
| pub ki_tsize: ::segsz_t, | ||
| /// Data size (pages) XXX. |
There was a problem hiding this comment.
What do these "XXX" markers mean here? Noticed them while doing a review for cargo-crev, got curious :) They're also present in all other versions of this struct.
There was a problem hiding this comment.
I have absolutely no idea. I took the comment as is.
| pub ki_numthreads: ::c_int, | ||
| // Thread ID. |
There was a problem hiding this comment.
Shouldn't this be a doc comment? (Ditto for other versions of this struct)
There was a problem hiding this comment.
Yes it should. Wanna send a PR?
Fix doc comment on FreeBSD `kinfo_proc` Cf. #2552 (comment)
Fix doc comment on FreeBSD `kinfo_proc` Cf. #2552 (comment)
Fix doc comment on FreeBSD `kinfo_proc` Cf. #2552 (comment)
Fix doc comment on FreeBSD `kinfo_proc` Cf. #2552 (comment)
It makes it much easier considering the huge number of fields...