Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos stop advertising mach crate which has no activity since 2019. #2287

Closed
wants to merge 1 commit into from
Closed

macos stop advertising mach crate which has no activity since 2019. #2287

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@devnexen
Copy link
Contributor Author

keeping the macro "just in case" but can be removed if wished

@JohnTitor
Copy link
Member

FYI: I'm contacting the repo owner to see if I can help maintain.

@devnexen
Copy link
Contributor Author

ah right I did not see your ticket sorry.

@JohnTitor
Copy link
Member

Well, I didn't mention it on the issue so it's not your fault :)

@Amanieu
Copy link
Member

Amanieu commented Jul 14, 2021

r? @JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned Amanieu Jul 14, 2021
@JohnTitor
Copy link
Member

So, the initial thought on the original PR was that the values on mach.h were often updated/deprecated and versioning here didn't fit it. Are they still updated often?

@devnexen
Copy link
Contributor Author

Not necessarily very often but still occur yes.

@bors
Copy link
Contributor

bors commented Sep 17, 2021

☔ The latest upstream changes (presumably #2401) made this pull request unmergeable. Please resolve the merge conflicts.

@devnexen
Copy link
Contributor Author

should we close this one or is it worthy to rebase ?

@JohnTitor
Copy link
Member

I don't mind either, but we should continue discussing on the issue.

@bors
Copy link
Contributor

bors commented Nov 16, 2021

☔ The latest upstream changes (presumably #2539) made this pull request unmergeable. Please resolve the merge conflicts.

@devnexen devnexen closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants