New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing dl lib on armv5te-unknown-linux-uclibceabi #2005
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
... I'm not sure why the freebsd test failed. I believe I haven't changed anything that would affect this target. |
Seems reasonable to me but I'd r? @joshtriplett as they're more familiar with this than me, I think (it's on the holiday season and the review may be delayed).
Because you're on the old branch and CI stuff is outdated. That failure should be resolved when testing on bors. |
Does uclibc actually have its own libutil, libdl, and similar? |
@joshtriplett I believe it does. See:
It's a list of files within the |
@joshtriplett Does it look good to you? |
Any progress here? |
I think this PR is fine. All uclibc targets are tier 3 so we're really just ensuring that it doesn't break tier 1/2 targets. @bors r+ |
📌 Commit 6df758a has been approved by |
🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened. |
@bors treeclosed- |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
I'm unable to link my executable for the Linux uClibc environment because of some missing symbols from the dl lib:
The libc crate is being used at both of these points.
This change fixes the issue for me. I've tested it with two different GCC cross toolchains for armv5te and it seems to be OK.
Note: I'm building my own std using the unstable build-std Cargo feature.