Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1952: Update CI name; replace with GitHub Actions #1969

Merged
merged 1 commit into from Nov 5, 2020
Merged

1952: Update CI name; replace with GitHub Actions #1969

merged 1 commit into from Nov 5, 2020

Conversation

Horki
Copy link
Contributor

@Horki Horki commented Nov 4, 2020

@lzutao fixes #1952 , please test

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Horki Horki mentioned this pull request Nov 4, 2020
Closed
JohnTitor
JohnTitor approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JohnTitor
Copy link
Member

Thanks for contributing :)
@bors r+

@bors
Copy link
Contributor

bors commented Nov 5, 2020

📌 Commit 05d5716 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Nov 5, 2020

⌛ Testing commit 05d5716 with merge d588f99...

@bors
Copy link
Contributor

bors commented Nov 5, 2020

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing d588f99 to master...

@bors bors merged commit d588f99 into rust-lang:master Nov 5, 2020
@Horki Horki deleted the 1952_update_contrib branch November 5, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI name in contributing.md
4 participants
@Horki @rust-highfive @JohnTitor @bors