New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and rearrange a few fcntl pieces #1756
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Closing and reopening to re-run CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition itself looks good to me but we need to tweak the test to pass CI.
@@ -504,6 +504,11 @@ s! { | |||
pub ee_info: u32, | |||
pub ee_data: u32, | |||
} | |||
|
|||
pub struct f_owner_ex { | |||
pub type_: ::c_int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add f_owner_ex
here:
Lines 2513 to 2522 in 0d37400
// The following structs have a field called `type` in C, | |
// but `type` is a Rust keyword, so these fields are translated | |
// to `type_` in Rust. | |
"type_" | |
if struct_ == "input_event" | |
|| struct_ == "input_mask" | |
|| struct_ == "ff_effect" => | |
{ | |
"type".to_string() | |
} |
☔ The latest upstream changes (presumably #2006) made this pull request unmergeable. Please resolve the merge conflicts. |
…the toplevel linux-like module because they're libc and platform agnostic.
I'm still not sure how to get this test to pass unfortunately. There appears to be something going wrong inside ctest, perhaps? |
Hey thanks for the ping and sorry for the long delay! If it will work properly with |
☔ The latest upstream changes (presumably #2233) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm going to close as inactive, feel free to rebase and re-open when you get some time :) |
Add f_owner_ex, F_GET/SETOWN_EX, F_GET/SETSIG, and move F_OWNER_* to the toplevel linux-like module because they're libc and platform agnostic.