MinGW: also copy libmingwex.a from C toolchain #1454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 63fd0f5 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 2, 2019
MinGW: also copy libmingwex.a from C toolchain
Fixes recent CI error:
```
note: C:\Program Files (x86)\Rust\lib\rustlib\i686-pc-windows-gnu\lib/libmsvcrt.a(dyims01169.o):(.text+0x0): multiple definition of `longjmp'
C:\Program Files (x86)\Rust\lib\rustlib\i686-pc-windows-gnu\lib/libmingwex.a(lib32_libmingwex_a-mingw_getsp.o):mingw_getsp.S:(.text+0x5): first defined here
```
Successful build: https://ci.appveyor.com/project/mati865/libc/builds/26425673
It also should be added to Azure in #1376
|
All green. |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Aug 2, 2019
MinGW: also copy libmingwex.a from C toolchain
Fixes recent CI error:
```
note: C:\Program Files (x86)\Rust\lib\rustlib\i686-pc-windows-gnu\lib/libmsvcrt.a(dyims01169.o):(.text+0x0): multiple definition of `longjmp'
C:\Program Files (x86)\Rust\lib\rustlib\i686-pc-windows-gnu\lib/libmingwex.a(lib32_libmingwex_a-mingw_getsp.o):mingw_getsp.S:(.text+0x5): first defined here
```
Successful build: https://ci.appveyor.com/project/mati865/libc/builds/26425673
It also should be added to Azure in #1376
|
💥 Test timed out |
|
@bors: r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 63fd0f5 has been approved by |
|
If #1376 is close to being merged you can close this one. |
|
I'm closing this in favor of that one, but bors is timing out all over the place all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes recent CI error:
Successful build: https://ci.appveyor.com/project/mati865/libc/builds/26425673
It also should be added to Azure in #1376