Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redox #1450

Closed
wants to merge 1 commit into from
Closed

Fix redox #1450

wants to merge 1 commit into from

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Jul 31, 2019

Revival of #1422

All the missing impls were added in #1438

Should unblock rust-lang/rust#61393

@mati865
Copy link
Contributor Author

mati865 commented Jul 31, 2019

Successful build: https://travis-ci.com/mati865/libc/builds/121390368

@newpavlov
Copy link
Contributor

newpavlov commented Jul 31, 2019

You will need to add Clone impls and define timezone) and probably remove derive of traits (or implement them manually) which cause failures here.

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 31, 2019

The derive of traits (except for Copy and Clone) aren't really necessary for anything, so you can just leave them all out.

@mati865
Copy link
Contributor Author

mati865 commented Jul 31, 2019

It was fixed in #1438

The build fails because of rust-lang/rust#63115 which will be fixed by rust-lang/rust#63122

@newpavlov
Copy link
Contributor

@gnzlbg
Can you re-run CI to see if the issue got fixed?

@mati865
Copy link
Contributor Author

mati865 commented Aug 4, 2019

CI is being migrated to Azure and will not succeed without #1376

@jackpot51
Copy link
Contributor

This is no longer required

@mati865
Copy link
Contributor Author

mati865 commented Aug 9, 2019

It won't be necessary for new nightly builds but libc is still empty when building for Redox from old nightly, beta or stable although I don't even know if they work after all those changes.

@jackpot51
Copy link
Contributor

I don't really see a use case for building for Redox prior to the 2019-08-08 nightly

@jackpot51
Copy link
Contributor

Anything doing that will need to be updated anyways

@bors
Copy link
Contributor

bors commented Aug 10, 2019

☔ The latest upstream changes (presumably #1408) made this pull request unmergeable. Please resolve the merge conflicts.

@mati865 mati865 closed this Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants