Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intial support for wasm32-unknown-wasi #1307

Merged
merged 3 commits into from Mar 28, 2019
Merged

Add intial support for wasm32-unknown-wasi #1307

merged 3 commits into from Mar 28, 2019

Commits on Mar 27, 2019

  1. Add intiial support for wasm32-unknown-wasi 

    This target is [being proposed][LINK] int he rust-lang/rust repository
and this is intended to get coupled with that proposal. The definitions
here all match the upstream reference-sysroot definitions and the
functions all match the reference sysroot as well. The linkage here is
described more in detail on the Rust PR itself, but in general it's
similar to musl.

Automatic verification has been implemented in the same manner as other
targets, and it's been used locally to develop this PR and catch errors
in the bindings already written (also to help match the evolving sysroot
of wasi). The verification isn't hooked up to CI yet though because
there is no wasi target distributed via rustup just yet, but once that's
done I'll file a follow-up PR to execute verification on CI.

[LINK]:
    @alexcrichton
    alexcrichton committed Mar 27, 2019
    Copy the full SHA
    87def1f View commit details
    Browse the repository at this point in the history

  2. Address some PR feedback

    @alexcrichton
    alexcrichton committed Mar 27, 2019
    Copy the full SHA
    8662b47 View commit details
    Browse the repository at this point in the history

  3. Touch up style of wasi.rs

    @alexcrichton
    alexcrichton committed Mar 27, 2019
    Copy the full SHA
    bce4454 View commit details
    Browse the repository at this point in the history