Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86_64-uclibc-l4re: fix syntax error + linter issues #1293

Merged
merged 2 commits into from Mar 3, 2019
Merged

x86_64-uclibc-l4re: fix syntax error + linter issues #1293

merged 2 commits into from Mar 3, 2019

Conversation

humenda
Copy link
Contributor

@humenda humenda commented Mar 2, 2019

  • fix syntax error in expand_align macro
  • fix errors due to doubly defined symbols / functions for
    x86_64-uclibc

@humenda
x86_64-uclibc-l4re: fix syntax error + linter issues
2c18025 
-   fix syntax error in expand_align macro
-   fix errors due to doubly defined symbols / functions for
    x86_64-uclibc
@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 2, 2019

LGTM!

@bors: r+

Unrelated question, could you contribute the target-specification json file that you are using with xargo to build whatever application you are building ? If you could add it to the libc/ci directory we could build libc for this target, and make sure that at least compilation does not break for the target. Thanks!

@bors
Copy link
Contributor

bors commented Mar 2, 2019

📌 Commit 2c18025 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Mar 2, 2019

⌛ Testing commit 2c18025 with merge 9721171...

bors added a commit that referenced this pull request Mar 2, 2019
@bors
Auto merge of #1293 - humenda:master, r=gnzlbg
9721171 
x86_64-uclibc-l4re: fix syntax error + linter issues

-   fix syntax error in expand_align macro
-   fix errors due to doubly defined symbols / functions for
    x86_64-uclibc
@bors
Copy link
Contributor

bors commented Mar 2, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 2, 2019

There are some style errors that should be fixed.

@humenda
Copy link
Contributor Author

humenda commented Mar 2, 2019 via email

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 3, 2019

@bors: retry

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 3, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 3, 2019

📌 Commit 3c8a493 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Mar 3, 2019

⌛ Testing commit 3c8a493 with merge 234f9a6...

bors added a commit that referenced this pull request Mar 3, 2019
@bors
Auto merge of #1293 - humenda:master, r=gnzlbg
234f9a6 
x86_64-uclibc-l4re: fix syntax error + linter issues

-   fix syntax error in expand_align macro
-   fix errors due to doubly defined symbols / functions for
    x86_64-uclibc
@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 3, 2019

FYI i've added a test that checks that this target properly builds on CI here: #1296

@bors
Copy link
Contributor

bors commented Mar 3, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 234f9a6 to master...

@bors bors merged commit 3c8a493 into rust-lang:master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gnzlbg gnzlbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@humenda @rust-highfive @gnzlbg @bors