Broader sendmmsg() / recvmmsg() support #1231
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
as OpenBSD doesn't have tests on CI, I will reply for it: OpenBSD doesn't support sendmmsg/recvmmsg syscalls.
|
|
|
|
Seems I broke (I hope! Looks like CI still fails, but with the same errors as before any of these changes.) |
|
@bors: r+ |
|
📌 Commit 0d3a600 has been approved by |
Broader sendmmsg() / recvmmsg() support As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc. The initial commits in this PR will just be to test out target support via CI.
|
💔 Test failed - checks-cirrus |
|
I've restarted the cirrus-ci build but it has been failing with:
This sounds like a temporary issue, but i've opened an issue with cirrus upstream just in case: cirruslabs/cirrus-ci-docs#131 |
|
@bors: retry |
Broader sendmmsg() / recvmmsg() support As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc. The initial commits in this PR will just be to test out target support via CI.
|
💔 Test failed - checks-cirrus |
|
Is cirrus better now? Worth a retry? |
|
@bors: retry |
|
cc @pietroalbani is @bors having some issues? |
Broader sendmmsg() / recvmmsg() support As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc. The initial commits in this PR will just be to test out target support via CI.
|
💥 Test timed out |
|
☔ The latest upstream changes (presumably #1247) made this pull request unmergeable. Please resolve the merge conflicts. |
Will likely alter this after seeing CI results across platforms.
I guess the previous lint failure was about avoiding #[cfg], and doing this instead.
|
Rebased onto master to resolve merge conflicts. Please retry 🙂 |
|
The last set of build failures seemed to be unrelated to these changes. If I have not understood the errors well, and there's something in there that I should address; please let me know! |
|
@bors: r+ |
|
📌 Commit d3c0eec has been approved by |
Broader sendmmsg() / recvmmsg() support As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc. The initial commits in this PR will just be to test out target support via CI.
|
💔 Test failed - checks-travis |
|
https://travis-ci.com/rust-lang/libc/jobs/176489419 failed with, https://travis-ci.com/rust-lang/libc/jobs/178288281 failed with, |
|
@bors: retry |
Broader sendmmsg() / recvmmsg() support As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc. The initial commits in this PR will just be to test out target support via CI.
|
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
As a prerequisite for getting
sendmmsg()/recvmmsg()into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc.The initial commits in this PR will just be to test out target support via CI.