Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style fixes #137

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Style fixes #137

wants to merge 4 commits into from

Conversation

samueltardieu
Copy link

@samueltardieu samueltardieu commented Dec 22, 2023 •
edited

Apply various style fixes found by Clippy:

  • Do not deconstruct an error to rebuild it right after
  • Remove useless as usize
  • Use char rather than &str as starts_with() argument
  • Remove useless references

@samueltardieu
Copy link
Author

I have separated the style fixes into various commits so that some could be removed if the maintainers prefer to let the code this way. This can be the case for the "Remove useless as usize" for example, as even though I don't find !0 as usize more readable than !0 (or usize::MAX as I would have used myself), some others may differ.

@samueltardieu samueltardieu force-pushed the style-fixes branch 2 times, most recently from a80c98b to 02a7fbe Compare December 22, 2023 20:30
@samueltardieu
Copy link
Author

Rebased on current master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@samueltardieu