On GLIBC, compile libgit2 with -D_FILE_OFFSET_BITS=64.
#862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On GLIBC, compile libgit2 with `-D_FILE_OFFSET_BITS=64`. On 32-bit architectures, this is needed for libgit2 to access files larger than 2 GiB. While here, also use `-D_TIME_BITS=64`, which is needed on GLIBC on 32-bit architectures for libgit2 to work correctly in in the year 2038 and beyond.
|
@sunfishcode To what extent does this change the public ABI of the libgit2 C library? If people are calling functions in libgit2-sys directly, will any of that code break? |
|
libgit2 uses its own typedefs for file offsets and times in its public API, specifically to avoid being affected by this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On GLIBC, compile libgit2 with
-D_FILE_OFFSET_BITS=64. On 32-bitarchitectures, this is needed for libgit2 to access files larger than 2 GiB.
While here, also use
-D_TIME_BITS=64, which is needed on GLIBC on 32-bitarchitectures for libgit2 to work correctly in in the year 2038 and beyond.