Implement minimal support for chained credential store helpers #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper entry is a multivar option. This allows chaining multiple helpers after each other.
When a helper returned some credential allow "store" helpers to save that credential. Helpers that don't understand the command will ignore this request. This enables the usage of the Git-bundled cache/store helpers.
mschlumpp
force-pushed
the
feature/chained-cred-helpers
branch
from
505f201
to
a3c6100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools such as git-credential-oauth rely on a chained helper configuration to store the acquired credentials.
Unimplemented features in this PR:
usernameandpassword(Notable other properties would bepassword_expiry_utc,oauth_refresh_token).password_expiry_utcproperty, and instead relies on thetimeoutconfig of the cache helper.Note:
git-credential-oauthdoes not seem to make use of these features at the moment.