Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sync impl of BiLockGuard #2570

Merged
merged 3 commits into from Feb 16, 2022
Merged

Fix Sync impl of BiLockGuard #2570

merged 3 commits into from Feb 16, 2022

Commits on Feb 13, 2022

  1. Fix Sync impl of BiLockGuard

    @taiki-e
    taiki-e committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    4d09b7a View commit details
    Browse the repository at this point in the history

  2. Fix stable_features warning 

    ```
error: the feature `cfg_target_has_atomic` has been stable since 1.60.0 and no longer requires an attribute to enable
 --> futures/tests/no-std/src/lib.rs:3:12
  |
3 | #![feature(cfg_target_has_atomic)]
  |            ^^^^^^^^^^^^^^^^^^^^^
```
    @taiki-e
    taiki-e committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    35a57e7 View commit details
    Browse the repository at this point in the history

  3. Fix clippy::single_match warning 

    ```
error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> futures-executor/src/thread_pool.rs:349:9
    |
349 | /         match arc_self.mutex.notify() {
350 | |             Ok(task) => arc_self.exec.state.send(Message::Run(task)),
351 | |             Err(()) => {}
352 | |         }
    | |_________^ help: try this: `if let Ok(task) = arc_self.mutex.notify() { arc_self.exec.state.send(Message::Run(task)) }`
    |
    = note: `-D clippy::single-match` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
```
    @taiki-e
    taiki-e committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    237f392 View commit details
    Browse the repository at this point in the history