Ordered stream utils #2517
Open
Ordered stream utils #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorag
commented
Nov 15, 2021
| fn gen_index(n: usize) -> usize { | ||
| pub fn gen_index(n: usize) -> usize { |
There was a problem hiding this comment.
I needed an rng for the 'delayed streams' tests. pub(crate) didn't seem to work for that, I guess because this is in futures-util and the tests are all in futures.
Comment on lines
+56
to
+64
| // For reference | ||
| // diff :: Ord a => [a] -> [a] -> [a] | ||
| // diff (x : xs) (y : ys) | ||
| // | x == y = diff xs ys | ||
| // | x < y = x : diff xs (y : ys) | ||
| // | x > y = diff (x : xs) ys | ||
| // diff xs [] = xs | ||
| // diff [] _ = [] | ||
|
|
There was a problem hiding this comment.
I prototyped the actual algorithm in Haskell. Happy to delete this if it's not helpful.
jmorag
force-pushed
the
ordered-stream-utils
branch
from
e06c362
to
fe03c97
Compare
|
Fixed the rest of the CI failures. Please let me know if you'd like me to squash everything from 4e01c51 on. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds utility functions for merge and diff operations on sorted streams in constant space. I had a problem at work where I needed to diff a sorted stream of database items with the keys of a bunch of s3 buckets. The generic versions of those functions seem generic enough to merit inclusion here.