Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async LineWriter fix #2131 #2477

Merged
merged 9 commits into from Oct 8, 2021
Merged

async LineWriter fix #2131 #2477

merged 9 commits into from Oct 8, 2021

Commits on Aug 20, 2021

  1. fill with boilerplate code

    FelipeLema committed Aug 20, 2021
    Copy the full SHA
    54743e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Copy the full SHA
    0fd0e5e View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2021

  1. get rid of LineWriterShim

    doing so saves me thinking on how to deal with pin and fields
    FelipeLema committed Aug 22, 2021
    Copy the full SHA
    5667198 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    c2d4356 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. first round of unit tests

    - translate `std::io::LineWriter`'s unit test
    - rename `inner` field to `buf_writer` to avoid confusion with
    `BufWriter::inner`
    - the above lead me to re-write the logic accordingly
    - add methods to access `buf_writer`'s fields
    - sorting out types, cannot compile for now
    FelipeLema committed Aug 23, 2021
    Copy the full SHA
    d019027 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. fix compilation

    FelipeLema committed Aug 24, 2021
    Copy the full SHA
    50a6095 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. add poll_write_vectored

    - default `poll_write_vectored` behaves differently of
    `std::io::LineWriter::write_vectored`
    - ported from
    https://github.com/rust-lang/rust/blob/673d0db5e393e9c64897005b470bfeb6d5aec61b/library/std/src/io/buffered/tests.rs
    - that code has lots of comments, you may wanna check it out
    - translated tests for `std` 's `line_vectored`
    - added `inner_poll_write_vectored` to keep code explicit and verbose
    FelipeLema committed Aug 29, 2021
    Copy the full SHA
    1163848 View commit details
    Browse the repository at this point in the history
  2. fix clippy

    FelipeLema committed Aug 29, 2021
    Copy the full SHA
    fadf686 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. simplify testing code

    FelipeLema committed Sep 2, 2021
    Copy the full SHA
    dbb3ec1 View commit details
    Browse the repository at this point in the history