Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport try_chunks to 0.3 #2465

Closed
wants to merge 1 commit into from
Closed

Backport try_chunks to 0.3 #2465

wants to merge 1 commit into from

Conversation

Ten0
Copy link

@Ten0 Ten0 commented Jul 23, 2021 •
edited

#2438 is marked as 0.3-backport: pending.
This is it. :) (cherry-picking 5f610f8)

Resolves #1947 (which specifically mentionned 0.3)

@Ten0
Backport try_chunks to 0.3
415ed37 
rust-lang#2438 is marked as `0.3-backport: pending`.
This is it. :)

Resolves rust-lang#1947 (which specifically mentionned 0.3)
@Ten0 Ten0 requested a review from taiki-e as a code owner July 23, 2021 17:48
@Ten0
Copy link
Author

Ten0 commented Jul 23, 2021 •
edited

CI fails appear to be unrelated, as these errors also show when running

cargo +nightly test --workspace --all-features

on branch 0.3

taiki-e
taiki-e reviewed Jul 23, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I'll open a backport PR with all other necessary changes (e.g., other 0.3-backport: pending PRs) later. So, closing this in favor of it.

@taiki-e taiki-e closed this Jul 23, 2021
@Ten0 Ten0 deleted the backport_try_chunks_03 branch July 23, 2021 18:01
@Ten0 Ten0 restored the backport_try_chunks_03 branch July 23, 2021 18:01
@Ten0
Copy link
Author

Ten0 commented Jul 23, 2021

Ok. Do you have an idea when we can expect that particular backport to be released?

@taiki-e
Copy link
Member

taiki-e commented Jul 23, 2021

Published 0.3.16.

Do you have an idea when we can expect that particular backport to be released?

In futures-rs, I usually create a new release in the following cases:

  • There was an unreleased patch to fix regression, unsoundness, or security issue. (e.g., 0.3.12)
  • Someone requested a new release. (e.g., 0.3.16)
  • Maintainer (mainly @taiki-e) felt that there were many unreleased patches, or wanted to create a new release for some reason. (e.g., 0.3.15)

@Ten0 Ten0 deleted the backport_try_chunks_03 branch July 23, 2021 19:25
@Ten0
Copy link
Author

Ten0 commented Jul 23, 2021

Thanks so much for your quick reaction! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ten0 @taiki-e